Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for keycloak saml attributes #806

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

nfoucha
Copy link
Contributor

@nfoucha nfoucha commented Sep 23, 2024

Description

Adds SAML fine grained attributes:
saml_assertion_consumer_url_redirect
saml_single_logout_service_url_post
saml_single_logout_service_url_redirect

Related Issue

Fixes #805

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@nfoucha nfoucha requested a review from a team as a code owner September 23, 2024 15:33
@UnicornChance
Copy link
Contributor

Unverified commit

@nfoucha looks like you had an unverified commit that will need to be resolved before we can merge this in. Definitely think this PR is valid and ready once you get that commit fixed.

@nfoucha
Copy link
Contributor Author

nfoucha commented Sep 23, 2024

@nfoucha looks like you had an unverified commit that will need to be resolved before we can merge this in. Definitely think this PR is valid and ready once you get that commit fixed.

@UnicornChance Guessing that happened when I did the rebase via UI, oops.

Copy link
Contributor

@UnicornChance UnicornChance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@UnicornChance UnicornChance merged commit b312b7d into main Sep 23, 2024
22 checks passed
@UnicornChance UnicornChance deleted the feat/add-saml-attributes branch September 23, 2024 20:00
noahpb pushed a commit that referenced this pull request Sep 25, 2024
## Description

Adds SAML fine grained attributes:
`saml_assertion_consumer_url_redirect`
`saml_single_logout_service_url_post`
`saml_single_logout_service_url_redirect`

## Related Issue

Fixes #805 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

Co-authored-by: Chance <139784371+UnicornChance@users.noreply.github.com>
docandrew pushed a commit that referenced this pull request Sep 25, 2024
## Description

Adds SAML fine grained attributes:
`saml_assertion_consumer_url_redirect`
`saml_single_logout_service_url_post`
`saml_single_logout_service_url_redirect`

## Related Issue

Fixes #805 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

Co-authored-by: Chance <139784371+UnicornChance@users.noreply.github.com>
UnicornChance added a commit that referenced this pull request Sep 26, 2024
## Description

Adds SAML fine grained attributes:
`saml_assertion_consumer_url_redirect`
`saml_single_logout_service_url_post`
`saml_single_logout_service_url_redirect`

## Related Issue

Fixes #805 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

Co-authored-by: Chance <139784371+UnicornChance@users.noreply.github.com>
mjnagel pushed a commit that referenced this pull request Sep 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.28.0](v0.27.3...v0.28.0)
(2024-09-27)


### ⚠ BREAKING CHANGES

* Promtail has been removed from UDS Core and replaced by Vector. If you
were previously using overrides to setup additional log
targets/endpoints for Promtail this configuration will need to be
updated to Vector's chart/config formats. See Vector's [Sources and
Sinks](https://vector.dev/components/) as well as the [helm chart
values](https://github.com/defenseunicorns/uds-core/blob/1bf29582f9c5b1fe01763e86e56c19b6e17aef85/src/vector/values/values.yaml#L4)
for guidance in configuration.

### Features

* add support for keycloak saml attributes
([#806](#806))
([b312b7d](b312b7d))
* exposes tls version for dev bundles
([#809](#809))
([e1a2b55](e1a2b55))
* switch from promtail to vector
(#724)
([1bf2958](1bf2958))


### Bug Fixes

* eks iac issues, document storage class pre-reqs
([#812](#812))
([df514bd](df514bd))
* ensure istio sidecar is killed if job fails
([#813](#813))
([34ffc0a](34ffc0a))
* revert test app version to fix CI failures
([#815](#815))
([2ec6ad6](2ec6ad6))


### Miscellaneous

* add runtime group to renovate config
([#799](#799))
([1bf2c69](1bf2c69))
* **deps:** update dependency defenseunicorns/uds-common to v0.13.0
([#790](#790))
([8bfcdc0](8bfcdc0))
* **deps:** update dependency defenseunicorns/uds-common to v0.13.1
([#810](#810))
([eedb551](eedb551))
* **deps:** update istio to v1.23.2
([#796](#796))
([039d89c](039d89c))
* **deps:** update keycloak to v25.0.6
([#771](#771))
([9864059](9864059))
* **deps:** update pepr to v0.13.1
([#811](#811))
([bc05b04](bc05b04))
* **deps:** update prometheus operator to v0.77.0
([#783](#783))
([8f383d8](8f383d8))
* **deps:** update runtime to v0.5.0
([#834](#834))
([edc068d](edc068d))
* **deps:** update setup-node to v4.0.4
([#801](#801))
([34dbc44](34dbc44))
* **deps:** update uds to v0.16.0
([#802](#802))
([d07670b](d07670b))
* **deps:** update uds-common to v0.13.0
([#792](#792))
([c24e833](c24e833))
* **deps:** update zarf to v0.40.1
([#793](#793))
([db93a7e](db93a7e))
* fix github-actions renovate
([#800](#800))
([3ab2add](3ab2add))
* pepr policies doc table
([#803](#803))
([440e4e1](440e4e1))
* pepr policy doc
([#814](#814))
([8b10b86](8b10b86))
* updated pepr watch limit to 60s
([#840](#840))
([85f3f41](85f3f41))
* use kfc WatchPhase enum
([#787](#787))
([df4d2da](df4d2da))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
docandrew pushed a commit that referenced this pull request Sep 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.28.0](v0.27.3...v0.28.0)
(2024-09-27)


### ⚠ BREAKING CHANGES

* Promtail has been removed from UDS Core and replaced by Vector. If you
were previously using overrides to setup additional log
targets/endpoints for Promtail this configuration will need to be
updated to Vector's chart/config formats. See Vector's [Sources and
Sinks](https://vector.dev/components/) as well as the [helm chart
values](https://github.com/defenseunicorns/uds-core/blob/1bf29582f9c5b1fe01763e86e56c19b6e17aef85/src/vector/values/values.yaml#L4)
for guidance in configuration.

### Features

* add support for keycloak saml attributes
([#806](#806))
([b312b7d](b312b7d))
* exposes tls version for dev bundles
([#809](#809))
([e1a2b55](e1a2b55))
* switch from promtail to vector
(#724)
([1bf2958](1bf2958))


### Bug Fixes

* eks iac issues, document storage class pre-reqs
([#812](#812))
([df514bd](df514bd))
* ensure istio sidecar is killed if job fails
([#813](#813))
([34ffc0a](34ffc0a))
* revert test app version to fix CI failures
([#815](#815))
([2ec6ad6](2ec6ad6))


### Miscellaneous

* add runtime group to renovate config
([#799](#799))
([1bf2c69](1bf2c69))
* **deps:** update dependency defenseunicorns/uds-common to v0.13.0
([#790](#790))
([8bfcdc0](8bfcdc0))
* **deps:** update dependency defenseunicorns/uds-common to v0.13.1
([#810](#810))
([eedb551](eedb551))
* **deps:** update istio to v1.23.2
([#796](#796))
([039d89c](039d89c))
* **deps:** update keycloak to v25.0.6
([#771](#771))
([9864059](9864059))
* **deps:** update pepr to v0.13.1
([#811](#811))
([bc05b04](bc05b04))
* **deps:** update prometheus operator to v0.77.0
([#783](#783))
([8f383d8](8f383d8))
* **deps:** update runtime to v0.5.0
([#834](#834))
([edc068d](edc068d))
* **deps:** update setup-node to v4.0.4
([#801](#801))
([34dbc44](34dbc44))
* **deps:** update uds to v0.16.0
([#802](#802))
([d07670b](d07670b))
* **deps:** update uds-common to v0.13.0
([#792](#792))
([c24e833](c24e833))
* **deps:** update zarf to v0.40.1
([#793](#793))
([db93a7e](db93a7e))
* fix github-actions renovate
([#800](#800))
([3ab2add](3ab2add))
* pepr policies doc table
([#803](#803))
([440e4e1](440e4e1))
* pepr policy doc
([#814](#814))
([8b10b86](8b10b86))
* updated pepr watch limit to 60s
([#840](#840))
([85f3f41](85f3f41))
* use kfc WatchPhase enum
([#787](#787))
([df4d2da](df4d2da))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Keycloak SAML attributes
2 participants